ENGTAI-64543: expose withGrpcConn to allow exporters to share connection#252
Merged
ENGTAI-64543: expose withGrpcConn to allow exporters to share connection#252
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #252 +/- ##
==========================================
- Coverage 47.79% 47.70% -0.09%
==========================================
Files 62 62
Lines 3013 3050 +37
==========================================
+ Hits 1440 1455 +15
- Misses 1499 1518 +19
- Partials 74 77 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I think creating connection explicitly will be better. This is good. |
tim-mwangi
approved these changes
Jul 15, 2025
varkey98
approved these changes
Jul 15, 2025
Collaborator
Author
|
@t-santoshsahu (default of 30s) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Originally I tried implementing this by storing a single global exporter and then each new registered service tracer would have it's own in memory exporter. This performed essentially the same(marginal benefit ~1% in benchmarks..)
As an alternative, otel exposes a
WithGRPCConnargument we can pass to each exporter. This keeps our implementation simpler and achieves essentially the same result.Since we need to have a reference to the shared connection the flow would be:
In my benchmarks using the WithGrpcConn option with 10 services and sending 10k spans per service:
(I used the gopsutil pkg for network tests and was reporting to local collector, so I think that may be messing up network stats specificall)