fix: Upgrade to angular v20 #1415
Conversation
Update from Angular v19 to v20
Added CLAUDE.md file
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1415 +/- ##
=======================================
Coverage 99.67% 99.67%
=======================================
Files 49 49
Lines 617 617
Branches 39 36 -3
=======================================
Hits 615 615
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| #!/bin/sh | ||
| . "$(dirname "$0")/_/husky.sh" | ||
|
|
There was a problem hiding this comment.
Husky no longer requires this stuff
| "@angular-devkit/build-angular": "^19.0.6", | ||
| "core-js": "^3.39.0", |
There was a problem hiding this comment.
These weren't used by the library
| "extends": "../../tsconfig.json", | ||
| "compilerOptions": { | ||
| "outDir": "../../out-tsc/spec", | ||
| "types": ["webpack-env", "jest"], |
There was a problem hiding this comment.
Webpack isn't used in this project
| "@angular/common": "^19.0.5", | ||
| "@angular/core": "^19.0.5", | ||
| "@angular/platform-browser": "^19.0.5", | ||
| "@angular-devkit/build-angular": "^19.0.6", |
There was a problem hiding this comment.
Thought this is used for build related stuff.
There was a problem hiding this comment.
Since this is a library, it doesn't get "built", it's up to the consuming app
There was a problem hiding this comment.
It does - because it gets packaged up and published. There's also an application this repo (src dir) that historically has been used for developing + debugging this library.
There was a problem hiding this comment.
This is in the package level, the app around it has the appropriate builders and everything builds fine
There was a problem hiding this comment.
npm run build:ci works 
|
I've been doing some debugging and found the v7.1.1 works fine under Angular 19. v8.0.0 is totally broken. This PR builds fine, but there is an issue reported in the console. Will investigate |
Fixed now. The changes that went into v8.0.0 removed initialisation calls. I've added a commit that puts them back in to the app. The package worked without this change, but the app was broken. 
|
|
🎉 This PR is included in version 8.0.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
3 participants
Description
Update the library to use Angular 20
Testing
Loaded within the outer Angular 20 app.
Checklist: