Skip to content

Conversation

@comicfans
Copy link

@comicfans comicfans commented Jul 3, 2016

original code search 640x480 as fallback resolution, and crash if not found,
but this resolution is not always avaible. this fix just return last resolution (which is lowest).
this may fix #60 (not confirmed)

@yamgent
Copy link

yamgent commented Jul 4, 2016

I feel that, instead of removing the assert completely, it should check for extreme cases where no resolutions were given at all, i.e.

ASSERT(_ctResolutions <= 0);

@comicfans
Copy link
Author

if no resolution avaible , can SDL video init successful ? (I've not check the whole logic flow, not sure if these resolution detected by SDL)

@yamgent
Copy link

yamgent commented Jul 6, 2016

The list of resolutions are not generated by SDL afaik.

That's kinda the point of assertions though, no need to second guess the assumptions, just test them :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to set custom resolution + Assertion Failed on Video menu

2 participants