Skip to content

Comments

Fix stacked DiD tutorial: remove warning from trimming fix cell#176

Merged
igerber merged 1 commit intomainfrom
fix-stacked-did-tutorial
Feb 20, 2026
Merged

Fix stacked DiD tutorial: remove warning from trimming fix cell#176
igerber merged 1 commit intomainfrom
fix-stacked-did-tutorial

Conversation

@igerber
Copy link
Owner

@igerber igerber commented Feb 20, 2026

Summary

  • Remove redundant StackedDiD(kappa_pre=3, kappa_post=3) call from the trimming fix cell in tutorial 13
  • The symmetric-kappa case re-emitted the trimming warning that was already shown and explained in preceding cells, undermining the narrative of "here's how to fix it"
  • The cell now only shows the asymmetric window solution, which genuinely runs warning-free

Methodology references (required if estimator / math changes)

  • N/A - no methodology changes (tutorial-only fix)

Validation

  • Tests added/updated: No test changes (tutorial narrative fix)
  • Backtest / simulation / notebook evidence: Tutorial cell output will no longer show a spurious warning

Security / privacy

  • Confirm no secrets/PII in this PR: Yes

Generated with Claude Code

The tutorial cell that demonstrates the asymmetric window fix was
re-running StackedDiD(kappa_pre=3, kappa_post=3), which re-emitted
the trimming warning that was already shown and explained in the
preceding cells. Remove it so the "fix" cell is warning-free.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions
Copy link

Overall Assessment: ✅ Looks good

Executive Summary

  • Simplifies the trimming-fix example by removing the redundant symmetric kappa run; asymmetric window example remains in docs/tutorials/13_stacked_did.ipynb:L242-L247.
  • No estimator, math, variance/SE, or assumption logic changes; StackedDiD methodology registry entry remains the reference (docs/methodology/REGISTRY.md:L643-L720).
  • Edge-case checklist and inference integrity are unaffected because no code paths changed; tests unchanged (reasonable for tutorial-only update).

Methodology
No findings. Tutorial-only edit; no estimator changes relative to the StackedDiD registry entry (docs/methodology/REGISTRY.md:L643-L720).

Code Quality
No findings.

Performance
No findings.

Maintainability
No findings.

Tech Debt
No findings.

Security
No findings.

Documentation/Tests
No findings. Tutorial-only update; no tests expected.

@igerber igerber merged commit 27fcc17 into main Feb 20, 2026
1 check passed
@igerber igerber deleted the fix-stacked-did-tutorial branch February 20, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant