Skip to content

Conversation

@floydianslips
Copy link
Contributor

This PR has a lot of changes to the files. Most of them are just formatting changes by VS Code. I don't have time to adjust the rules I have setup for VS code so if you are interested in the changes without the formatting let me know.

@holta
Copy link
Member

holta commented Jan 17, 2022

@floydianslips can you throw a screenshot onto this ticket?

(To help others understand what's being proposed?)

@tim-moody
Copy link
Contributor

I'm worried about the regression in cmdsrv3.py ctl_bluetooth.

Also the change in formatting makes it very difficult to find the actual changes, though it is more readable. (BTW I use space, not tabs and 2 columns for html, css, js.)

Any way you could:
pull upstream master
branch
save the three files in VSS to change the format
branch
apply your changes
show a diff between the two branches

@tim-moody
Copy link
Contributor

I've been through this quite a few times. Would I be right in thinking that apart from all the format changes, the real changes are in js-menu.css:

color: red;
}

.slide-menu .icon-link {
  padding-right: 10px;
}

.kiwixsearch {
  padding: 10px;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants