Skip to content

Fix typo in apply_threshold #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ehrenfeu merged 1 commit into from
Jan 16, 2026
Merged

Fix typo in apply_threshold #121

ehrenfeu merged 1 commit into from
Jan 16, 2026

Conversation

@rohangirishrao
Copy link
Contributor

@rohangirishrao rohangirishrao commented Jan 14, 2026 •
edited by ehrenfeu
Loading

Fix simple typo do_3d in method body (issue #113).

@rohangirishrao rohangirishrao changed the title Fix typo in method body Fix typo, fixing issue #113 Jan 14, 2026
@codecov
Copy link

codecov bot commented Jan 14, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 24%. Comparing base (ce66eef) to head (598bff9).
⚠️ Report is 44 commits behind head on devel.

Additional details and impacted files 
@@         Coverage Diff          @@
##           devel   #121   +/-   ##
====================================
- Coverage     25%    24%   -0%     
====================================
  Files         25     25           
  Lines       1711   1720    +9     
====================================
  Hits         421    421           
- Misses      1290   1299    +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rohangirishrao rohangirishrao mentioned this pull request Jan 14, 2026
Closed
@rohangirishrao rohangirishrao added bug Something isn't working new-minor Change introduced in PR will require a new minor release. labels Jan 14, 2026
@ehrenfeu ehrenfeu changed the title Fix typo, fixing issue #113 Fix typo in apply_threshold Jan 16, 2026
@ehrenfeu ehrenfeu self-requested a review January 16, 2026 13:23
@ehrenfeu ehrenfeu moved this to In review in imcflibs Jan 16, 2026
@ehrenfeu ehrenfeu added this to the 2.0.0 milestone Jan 16, 2026
@ehrenfeu ehrenfeu linked an issue Jan 16, 2026 that may be closed by this pull request
Mistake while referencing parameter in method body #113
Closed
@ehrenfeu ehrenfeu merged commit 5989a4d into imcf:devel Jan 16, 2026
3 of 5 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in imcflibs Jan 16, 2026
@rohangirishrao rohangirishrao deleted the fix-apply-threshold branch January 16, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehrenfeu ehrenfeu Awaiting requested review from ehrenfeu

Assignees

@rohangirishrao rohangirishrao

Labels

bug Something isn't working new-minor Change introduced in PR will require a new minor release.

Projects

imcflibs
Status: Done

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

Mistake while referencing parameter in method body

2 participants

@rohangirishrao @ehrenfeu