Skip to content

Conversation

@lguerard
Copy link
Contributor

Should fix #129

* Set default value of channel_source to 0 in duplicate_transformations function.
* Update error handling to raise ValueError instead of exiting the program.
* Adjust logic to handle channel_source correctly when generating source string.
@lguerard lguerard changed the base branch from master to devel January 19, 2026 10:07
@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 24%. Comparing base (73268dd) to head (ec9ab9e).
⚠️ Report is 58 commits behind head on devel.

Files with missing lines Patch % Lines
src/imcflibs/imagej/bdv.py 0% 5 Missing ⚠️
Additional details and impacted files
@@         Coverage Diff          @@
##           devel   #131   +/-   ##
====================================
- Coverage     24%    24%   -0%     
====================================
  Files         25     25           
  Lines       1746   1748    +2     
====================================
  Hits         425    425           
- Misses      1321   1323    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ehrenfeu ehrenfeu added the conventions Issue with formatting / naming / ... label Jan 19, 2026
@ehrenfeu ehrenfeu moved this to In review in imcflibs Jan 19, 2026
@ehrenfeu ehrenfeu added this to the 2.0.0 milestone Jan 19, 2026
@ehrenfeu ehrenfeu merged commit ad1d60e into imcf:devel Jan 19, 2026
3 of 5 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in imcflibs Jan 19, 2026
@lguerard lguerard deleted the fix/129_bdv_variable_type_mixup branch January 22, 2026 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conventions Issue with formatting / naming / ...

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Variable type mixup for channel_source

2 participants