Skip to content

fix: improve higher order type inference for WritableDraft #1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
unional wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: improve higher order type inference for WritableDraft #1205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions __tests__/produce.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,3 +758,15 @@ it("allows for mixed property value types", () => {
}
})
})

it("allows higher order type inference", () => {
function _test<A>() {
type S = {prop: A | undefined}
produce(
draft => {
draft.prop = undefined
},
{prop: undefined} as S
)
}
})
2 changes: 1 addition & 1 deletion src/types/types-external.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export type WritableDraft<T> = T extends any[]
: WritableNonArrayDraft<T>

type WritableNonArrayDraft<T> = {
-readonly [K in keyof T]: T[K] extends infer V
-readonly [K in keyof T]: {_: T[K]} extends {_: infer V}
? V extends object
? Draft<V>
: V
Expand Down
Loading