Skip to content

[DX-3548] feat: swap api key #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nattb8 merged 3 commits into from
Jan 28, 2025
Merged

[DX-3548] feat: swap api key #385

nattb8 merged 3 commits into from
Jan 28, 2025

Conversation

@nattb8
Copy link
Collaborator

@nattb8 nattb8 commented Jan 27, 2025 •
edited
Loading

Summary

  • Removed the hardcoded Swap API key as developers need to get the key from Immutable Hub.
  • Refactored on-ramp params
  • Fixed sample app select auth method scene missing font
  • Updated sample app text

Other things to consider:

@nattb8 nattb8 requested a review from a team January 27, 2025 01:28
@nattb8 nattb8 merged commit b1d1dd1 into main Jan 28, 2025
18 checks passed
@nattb8 nattb8 deleted the feat/swap-api-key branch January 28, 2025 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ImmutableJeffrey ImmutableJeffrey ImmutableJeffrey approved these changes

+1 more reviewer

@YermekG YermekG YermekG approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nattb8 @YermekG @ImmutableJeffrey