Skip to content

Conversation

@shenxiangzhuang
Copy link
Contributor

No description provided.

Copy link
Collaborator

@JacksonMei JacksonMei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add the missing Docker dependency to pyproject.toml - this might completely resolve the issue.

@shenxiangzhuang
Copy link
Contributor Author

You can add the missing Docker dependency to pyproject.toml - this might completely resolve the issue.

OK, this will be beter.

@shenxiangzhuang shenxiangzhuang marked this pull request as draft December 21, 2025 04:54
@shenxiangzhuang
Copy link
Contributor Author

Hi @JacksonMei , I think the uv.lock file should be fixed before we add the docker package.

Firstly, the version number seems not the newest, which should be updated. Secondly, the lock file use tsinghua's mirror as uv index url, we should consider to change it to official pypi source. Otherwise, when contributors use diferent source other than tsinghua mirror, the lock file will be fully updated to their source index.

@JacksonMei
Copy link
Collaborator

Hi @JacksonMei , I think the uv.lock file should be fixed before we add the docker package.

Firstly, the version number seems not the newest, which should be updated. Secondly, the lock file use tsinghua's mirror as uv index url, we should consider to change it to official pypi source. Otherwise, when contributors use diferent source other than tsinghua mirror, the lock file will be fully updated to their source index.

yes, you are right, and you can submit an issue for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants