Refactored the test files with helpers to test backend#16
Open
yangchenyun wants to merge 1 commit intoinetaf:masterfrom
Open
Refactored the test files with helpers to test backend#16yangchenyun wants to merge 1 commit intoinetaf:masterfrom
yangchenyun wants to merge 1 commit intoinetaf:masterfrom
Conversation
``` func testRouteToBackend(t *testing.T, front net.Listener, back net.Listener, msg string) func testNotRouteToBackend(t *testing.T, front net.Listener, back net.Listener, msg string) <-chan bool ```
yangchenyun
force-pushed
the
test_method_refactoring
branch
from
1be8ffa to
7e4f85b
Compare
Author
|
Ping for a look. |
Author
|
ping? |
Collaborator
|
The returned channel is weird. And the helpers are both undocumented. What's the point of this? The PR just says it's "refactored" ... but why? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the test by extracting the following two methods:
This change is