Skip to content

Fix splice optimization#47

Open
rchernobelskiy wants to merge 1 commit intoinetaf:masterfrom
rchernobelskiy:patch-1
Open

Fix splice optimization#47
rchernobelskiy wants to merge 1 commit intoinetaf:masterfrom
rchernobelskiy:patch-1

Conversation

@rchernobelskiy
Copy link

The intended behavior from the comment is not taking place:

// Unwrap the src and dst from *Conn to *net.TCPConn so Go
// 1.11's splice optimization kicks in.
src = UnderlyingConn(src)
dst = UnderlyingConn(dst)

The UnderlyingConn func doesn't return a *net.TCPConn so I think the intention here was to call tcpConn instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant