[GP-33873] Make php 8.4 changes #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crease29
suggested changes
Nov 28, 2025
| ## Forked version to add namespacing | ||
|
|
||
| ### 5.0.3 | ||
| * Make some php 8.4 related changes |
Member
There was a problem hiding this comment.
IMO this is a breaking change and should be reflected by bumping the minor version number, instead of the patch version number.
Member
There was a problem hiding this comment.
I'd expect the PHP version requirement to be increased. Some of the changes, like typed constants, aren't available in the currently required PHP version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added rector and made some changes for php 8.4 (they are not necessarily required but to avoid spam and keep up to date)