Skip to content

Conversation

@Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Dec 4, 2025

Description

Refactored "Catalyst Signed Document" validation rules, definitions. Provided a trait with a possibility to extend a validation rule set for a specific document type.

Related Issue(s)

Closes #673

Description of Changes

  • Refactored CatalystIdProvider and CatalystSignedDocumentProvider by using async_trait crate.
  • Added CatalystSignedDocumentAndCatalystIdProvider super trait of CatalystIdProvider and CatalystSignedDocumentProvider.
  • Added new CatalystSignedDocumentValidationRule trait and implement it for all existing validation rules like IdRule, VerRule etc.
  • Rewritten Rules structure to be a type Rules = Vec<Box<dyn CatalystSignedDocumentValidationRule>>
  • Added extend_rules_per_document public function

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@Mr-Leshiy Mr-Leshiy self-assigned this Dec 4, 2025
@Mr-Leshiy Mr-Leshiy added draft Draft squad: gatekeepers Catalyst App Backend, System Development & Integration Team labels Dec 4, 2025
@Mr-Leshiy Mr-Leshiy moved this from New to 🏗 In progress in Catalyst Dec 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

📚 Docs Preview

The docs for this PR can be previewed at the following URL:

https://docs.dev.projectcatalyst.io/libs/feat/doc-extended-validation

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

Test Report | ${\color{lightgreen}Pass: 601/601}$ | ${\color{red}Fail: 0/601}$ |

@Mr-Leshiy Mr-Leshiy added review me PR is ready for review and removed draft Draft labels Dec 5, 2025
Copy link
Member

@stanislav-tkach stanislav-tkach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Mr-Leshiy Mr-Leshiy merged commit 9f3f3a3 into main Dec 8, 2025
23 checks passed
@Mr-Leshiy Mr-Leshiy deleted the feat/doc-extended-validation branch December 8, 2025 04:45
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Catalyst Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Catalyst Signed Document extendable type specific validation

3 participants