Skip to content

fixes unit ec2-name #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JamesKunstle wants to merge 1 commit into from
Closed

fixes unit ec2-name #399

JamesKunstle wants to merge 1 commit into from

Conversation

@JamesKunstle
Copy link
Contributor

@JamesKunstle JamesKunstle commented Jan 17, 2025

used the wrong environment variable for setting up the instance that we'd like to run our unit tests with.

@JamesKunstle
fixes unit ec2-name
af33089 
Signed-off-by: James Kunstle <jkunstle@redhat.com>
@JamesKunstle JamesKunstle marked this pull request as ready for review January 17, 2025 00:37
@JamesKunstle JamesKunstle self-assigned this Jan 17, 2025
@mergify mergify bot added CI/CD Affects CI/CD configuration ci-failure labels Jan 17, 2025
danmcp
danmcp reviewed Jan 17, 2025
View reviewed changes
Copy link
Member

@danmcp danmcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear on the intention of this PR vs #395

@JamesKunstle
Copy link
Contributor Author

JamesKunstle commented Jan 17, 2025

@danmcp I'm not sure what the proposed solution is in #395- this solution is to use the correct environment variable to specify the instance type to test with. I think they're trying to do the same thing, roughly.

@JamesKunstle
Copy link
Contributor Author

JamesKunstle commented Jan 23, 2025

Replacing this PR with one that's based on a branch inside this repo:
#409

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RobotSail RobotSail Awaiting requested review from RobotSail

1 more reviewer

@danmcp danmcp danmcp left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@JamesKunstle JamesKunstle

Labels

CI/CD Affects CI/CD configuration ci-failure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JamesKunstle @danmcp