Setup Github Action workflow for auto cherry picking commits #488
Conversation
…n to release Signed-off-by: Aditya Gidh <aagidh@us.ibm.com>
Signed-off-by: Aditya Gidh <aagidh@us.ibm.com>
Signed-off-by: Aditya Gidh <aagidh@us.ibm.com>
vishnoianil
left a comment
vishnoianil
left a comment
There was a problem hiding this comment.
This is great! @adigidh . One question, i think with this implementation, it will cherry-pick every PR to the release-1.0 branch, but we would like to cherry-pick only if the PR is tagged with cherry-pick-release-1.0 label.
Signed-off-by: Aditya Gidh <aagidh@us.ibm.com>
@vishnoianil : Thank you for taking a look. I made an update to add some conditional logic in the YAML. This will ensure that the cherry-pick action only runs when a PR is merged and the specific label |
.github/workflows/cherry-pick.yml
Outdated
| jobs: | ||
| cherry_pick_release_1_0: | ||
| cherry_pick: | ||
| if: github.event.pull_request.merged == true && contains(github.event.pull_request.labels.*.name, 'cherry-pick release-1.0') |
There was a problem hiding this comment.
minor nit : the existing label name is "cherry-pick-release-1.0"
There was a problem hiding this comment.
Good catch! My bad, updated and pushed the correct label name.
@adigidh minor comment, but otherwise PR looks good. Once you address the comment, will merge the PR. |
Signed-off-by: Aditya Gidh <aagidh@us.ibm.com>
vishnoianil
left a comment
vishnoianil
left a comment
There was a problem hiding this comment.
LGTM, thanks for the PR, appreciate it @adigidh
|
@adigidh Merged the PR, can you test this by creating a simple PR (e.g minor change in the readme file) and I can merge it to master and let's see if the job automatically cherry-pick it for release-1.0 branch. |
|
@vishnoianil : created #493 to test this workflow out |
2 participants
fixes #484