-
Notifications
You must be signed in to change notification settings - Fork 56
Installer to install the UI stack in native mode on Podman. #528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installer to install the UI stack in native mode on Podman. #528
Conversation
dbecf3a to
0de090f
Compare
|
@nerdalert @Gregory-Pereira @cooktheryan Example install: Example uninstall: |
0de090f to
6538ad4
Compare
| } else { | ||
| // Use ilab from virtual environment | ||
| srv.ilabCmd = filepath.Join(srv.baseDir, "venv", "bin", "ilab") | ||
| srv.ilabCmd = filepath.Join(srv.baseDir, "bin", "ilab") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this break the api server running in the default namespace if ilab isn’t copied into PATH? Add a flag if so plx sir.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nerdalert venv is the name of virtual environment, user is to free to choose any name when they create the virtual environment. This installer now pass the entire path <venv-path>/<venv-name> to the apiserver. In this case it would be <venv-path>/venv. does that break anything in the apiserver?
nerdalert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
3de082d to
2b639dc
Compare
Also fixes: Updated Makefile and api-server github job to build binaries with CGO_ENABLED=1 Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
2b639dc to
a99521b
Compare
No description provided.