Skip to content

Conversation

@Gregory-Pereira
Copy link
Collaborator

Resolves: #460.

This is currently in the draft stage. I was told to start discussions with @Misjohns and Megan Hall (not sure what her handle on github is)

Signed-off-by: greg pereira <grpereir@redhat.com>
Signed-off-by: greg pereira <grpereir@redhat.com>
Signed-off-by: greg pereira <grpereir@redhat.com>
Signed-off-by: greg pereira <grpereir@redhat.com>
Signed-off-by: greg pereira <grpereir@redhat.com>
Signed-off-by: greg pereira <grpereir@redhat.com>
@Gregory-Pereira Gregory-Pereira force-pushed the custom-model-endpoint-redesign branch from 3e4d0e8 to d9fcecb Compare March 20, 2025 23:58
@Gregory-Pereira
Copy link
Collaborator Author

cc @kaedward, this is the draft PR. As I get closer to done Ill start posting some screenshots / caps

Signed-off-by: greg pereira <grpereir@redhat.com>
Signed-off-by: greg pereira <grpereir@redhat.com>
Signed-off-by: greg pereira <grpereir@redhat.com>
Signed-off-by: greg pereira <grpereir@redhat.com>
@Gregory-Pereira Gregory-Pereira force-pushed the custom-model-endpoint-redesign branch from 67b6730 to b4721d4 Compare April 16, 2025 15:01
Signed-off-by: greg pereira <grpereir@redhat.com>
Signed-off-by: greg pereira <grpereir@redhat.com>
@Gregory-Pereira Gregory-Pereira force-pushed the custom-model-endpoint-redesign branch 2 times, most recently from 7e05dd8 to d091cb2 Compare April 16, 2025 16:47
Comment on lines 389 to 419
<Button variant="secondary" onClick={() => {
setEndpointOptionsOpen(!endpointOptionsOpen)
setEndpointOptionsID(endpoint.id)
}}>
<EllipsisVIcon/>
</Button>
{endpointOptionsOpen && endpointOptionsID == endpoint.id ? (
<Dropdown
onOpenChange={() => { setEndpointOptionsID(endpoint.id); setEndpointOptionsOpen(true)}}
onSelect={() => {setEndpointOptionsID(endpoint.id); setEndpointOptionsOpen(false)}}
toggle={(toggleRef) => (
<MenuToggle
aria-label="actions"
variant="plain"
ref={toggleRef}
onClick={() => {
setEndpointOptionsID(endpoint.id);
setEndpointOptionsOpen(!endpointOptionsOpen)}
}
isExpanded={endpointOptionsOpen}
>
</MenuToggle>
)}
isOpen={endpointOptionsOpen}
ouiaId="ModelEndpointDropdown"
>
<DropdownList>
<DropdownItem onClick={() => handleEditEndpoint(endpoint)}>Edit Endpoint</DropdownItem>
<DropdownItem key="delete" style={{ color: "red"}} onClick={() => setDeleteEndpointModalOpen(true)}>Delete Endpoint</DropdownItem>
</DropdownList>
</Dropdown>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Button variant="secondary" onClick={() => {
setEndpointOptionsOpen(!endpointOptionsOpen)
setEndpointOptionsID(endpoint.id)
}}>
<EllipsisVIcon/>
</Button>
{endpointOptionsOpen && endpointOptionsID == endpoint.id ? (
<Dropdown
onOpenChange={() => { setEndpointOptionsID(endpoint.id); setEndpointOptionsOpen(true)}}
onSelect={() => {setEndpointOptionsID(endpoint.id); setEndpointOptionsOpen(false)}}
toggle={(toggleRef) => (
<MenuToggle
aria-label="actions"
variant="plain"
ref={toggleRef}
onClick={() => {
setEndpointOptionsID(endpoint.id);
setEndpointOptionsOpen(!endpointOptionsOpen)}
}
isExpanded={endpointOptionsOpen}
>
</MenuToggle>
)}
isOpen={endpointOptionsOpen}
ouiaId="ModelEndpointDropdown"
>
<DropdownList>
<DropdownItem onClick={() => handleEditEndpoint(endpoint)}>Edit Endpoint</DropdownItem>
<DropdownItem key="delete" style={{ color: "red"}} onClick={() => setDeleteEndpointModalOpen(true)}>Delete Endpoint</DropdownItem>
</DropdownList>
</Dropdown>
<Dropdown
onSelect={() => setEndpointOptionsOpen(false)}
toggle={(toggleRef) => (
<MenuToggle
aria-label="actions"
variant="plain"
ref={toggleRef}
onClick={() => {
setEndpointOptionsOpen(!endpointOptionsOpen);
setEndpointOptionsID(endpoint.id);
}}
isExpanded={endpointOptionsOpen && endpointOptionsID === endpoint.id}
>
<EllipsisVIcon />
</MenuToggle>
)}
isOpen={endpointOptionsOpen && endpointOptionsID === endpoint.id}
popperProps={{ position: 'right' }}
ouiaId="ModelEndpointDropdown"
>
<DropdownList>
<DropdownItem onClick={() => handleEditEndpoint(endpoint)}>Edit Endpoint</DropdownItem>
<DropdownItem key="delete" style={{ color: "red"}} onClick={() => setDeleteEndpointModalOpen(true)}>Delete Endpoint</DropdownItem>
</DropdownList>
</Dropdown>```

Signed-off-by: greg pereira <grpereir@redhat.com>
@Gregory-Pereira Gregory-Pereira force-pushed the custom-model-endpoint-redesign branch from d091cb2 to c8c92cc Compare April 16, 2025 18:16
@vishnoianil
Copy link
Member

@Gregory-Pereira is this PR ready for review? Anything that needs to be address to merge it?

@vishnoianil
Copy link
Member

This PR is updated and merged through #741 . Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve design of Custom Model Endpoint

3 participants