-
Notifications
You must be signed in to change notification settings - Fork 56
WIP: Custom model endpoint redesign #673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Gregory-Pereira
wants to merge
13
commits into
instructlab:main
from
Gregory-Pereira:custom-model-endpoint-redesign
Closed
WIP: Custom model endpoint redesign #673
Gregory-Pereira
wants to merge
13
commits into
instructlab:main
from
Gregory-Pereira:custom-model-endpoint-redesign
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: greg pereira <grpereir@redhat.com>
Signed-off-by: greg pereira <grpereir@redhat.com>
Signed-off-by: greg pereira <grpereir@redhat.com>
Signed-off-by: greg pereira <grpereir@redhat.com>
Signed-off-by: greg pereira <grpereir@redhat.com>
Signed-off-by: greg pereira <grpereir@redhat.com>
3e4d0e8 to
d9fcecb
Compare
Collaborator
Author
|
cc @kaedward, this is the draft PR. As I get closer to done Ill start posting some screenshots / caps |
Signed-off-by: greg pereira <grpereir@redhat.com>
Signed-off-by: greg pereira <grpereir@redhat.com>
Signed-off-by: greg pereira <grpereir@redhat.com>
67b6730 to
b4721d4
Compare
Signed-off-by: greg pereira <grpereir@redhat.com>
Signed-off-by: greg pereira <grpereir@redhat.com>
7e05dd8 to
d091cb2
Compare
Comment on lines
389
to
419
| <Button variant="secondary" onClick={() => { | ||
| setEndpointOptionsOpen(!endpointOptionsOpen) | ||
| setEndpointOptionsID(endpoint.id) | ||
| }}> | ||
| <EllipsisVIcon/> | ||
| </Button> | ||
| {endpointOptionsOpen && endpointOptionsID == endpoint.id ? ( | ||
| <Dropdown | ||
| onOpenChange={() => { setEndpointOptionsID(endpoint.id); setEndpointOptionsOpen(true)}} | ||
| onSelect={() => {setEndpointOptionsID(endpoint.id); setEndpointOptionsOpen(false)}} | ||
| toggle={(toggleRef) => ( | ||
| <MenuToggle | ||
| aria-label="actions" | ||
| variant="plain" | ||
| ref={toggleRef} | ||
| onClick={() => { | ||
| setEndpointOptionsID(endpoint.id); | ||
| setEndpointOptionsOpen(!endpointOptionsOpen)} | ||
| } | ||
| isExpanded={endpointOptionsOpen} | ||
| > | ||
| </MenuToggle> | ||
| )} | ||
| isOpen={endpointOptionsOpen} | ||
| ouiaId="ModelEndpointDropdown" | ||
| > | ||
| <DropdownList> | ||
| <DropdownItem onClick={() => handleEditEndpoint(endpoint)}>Edit Endpoint</DropdownItem> | ||
| <DropdownItem key="delete" style={{ color: "red"}} onClick={() => setDeleteEndpointModalOpen(true)}>Delete Endpoint</DropdownItem> | ||
| </DropdownList> | ||
| </Dropdown> |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| <Button variant="secondary" onClick={() => { | |
| setEndpointOptionsOpen(!endpointOptionsOpen) | |
| setEndpointOptionsID(endpoint.id) | |
| }}> | |
| <EllipsisVIcon/> | |
| </Button> | |
| {endpointOptionsOpen && endpointOptionsID == endpoint.id ? ( | |
| <Dropdown | |
| onOpenChange={() => { setEndpointOptionsID(endpoint.id); setEndpointOptionsOpen(true)}} | |
| onSelect={() => {setEndpointOptionsID(endpoint.id); setEndpointOptionsOpen(false)}} | |
| toggle={(toggleRef) => ( | |
| <MenuToggle | |
| aria-label="actions" | |
| variant="plain" | |
| ref={toggleRef} | |
| onClick={() => { | |
| setEndpointOptionsID(endpoint.id); | |
| setEndpointOptionsOpen(!endpointOptionsOpen)} | |
| } | |
| isExpanded={endpointOptionsOpen} | |
| > | |
| </MenuToggle> | |
| )} | |
| isOpen={endpointOptionsOpen} | |
| ouiaId="ModelEndpointDropdown" | |
| > | |
| <DropdownList> | |
| <DropdownItem onClick={() => handleEditEndpoint(endpoint)}>Edit Endpoint</DropdownItem> | |
| <DropdownItem key="delete" style={{ color: "red"}} onClick={() => setDeleteEndpointModalOpen(true)}>Delete Endpoint</DropdownItem> | |
| </DropdownList> | |
| </Dropdown> | |
| <Dropdown | |
| onSelect={() => setEndpointOptionsOpen(false)} | |
| toggle={(toggleRef) => ( | |
| <MenuToggle | |
| aria-label="actions" | |
| variant="plain" | |
| ref={toggleRef} | |
| onClick={() => { | |
| setEndpointOptionsOpen(!endpointOptionsOpen); | |
| setEndpointOptionsID(endpoint.id); | |
| }} | |
| isExpanded={endpointOptionsOpen && endpointOptionsID === endpoint.id} | |
| > | |
| <EllipsisVIcon /> | |
| </MenuToggle> | |
| )} | |
| isOpen={endpointOptionsOpen && endpointOptionsID === endpoint.id} | |
| popperProps={{ position: 'right' }} | |
| ouiaId="ModelEndpointDropdown" | |
| > | |
| <DropdownList> | |
| <DropdownItem onClick={() => handleEditEndpoint(endpoint)}>Edit Endpoint</DropdownItem> | |
| <DropdownItem key="delete" style={{ color: "red"}} onClick={() => setDeleteEndpointModalOpen(true)}>Delete Endpoint</DropdownItem> | |
| </DropdownList> | |
| </Dropdown>``` |
Signed-off-by: greg pereira <grpereir@redhat.com>
d091cb2 to
c8c92cc
Compare
Member
|
@Gregory-Pereira is this PR ready for review? Anything that needs to be address to merge it? |
Member
|
This PR is updated and merged through #741 . Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #460.
This is currently in the draft stage. I was told to start discussions with @Misjohns and Megan Hall (not sure what her handle on github is)