refactor(ui-view,ui-flex): add examples on how to override sharedTokens, fix docs console errors #2382
+79
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns, fix docs console errors
matyasf
commented
Jan 27, 2026
| </InstUISettingsProvider> | ||
| ``` | ||
|
|
||
| ### Overriding theme for a specific component in a subtree |
Collaborator
Author
There was a problem hiding this comment.
these are handled as array keys, so if there is a duplicate like here React will emit an error
matyasf
commented
Jan 27, 2026
Comment on lines
+386
to
+391
| legacy: { | ||
| radiusSmall: '2rem', // View border radius | ||
| }, | ||
| strokeWidth: { | ||
| sm: '1rem' // View border width | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
These will likely change, I just wanted to make sure that the current state works
|
HerrTopi
requested changes
Jan 30, 2026
| <View focusWithin> | ||
| if the <code>focusWithin</code> prop is <code>true</code>, the View will display the focus ring if any of its descendants receives focus | ||
| <div tabindex="0" role="button" style={{outline: 'none'}}>Tab here to see the focus outline</div> | ||
| <div tabIndex="0" role="button" style={{outline: 'none'}}>Tab here to see the focus outline</div> |
Contributor
There was a problem hiding this comment.
I shouldn't be capitalized in tabindex
|
|
||
| ### Theme overrides for focus rings, border radii, shadows, spacing | ||
|
|
||
| Certain visuals as now styled via a central object called `SharedTokens`. You can override this too, for example: |
Contributor
There was a problem hiding this comment.
Just a small grammatical thing: as OF now. At least I think so
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test: