feat: add github_release_asset data source #2514
Open
+550
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdb
force-pushed
the
mdb/gh-release-asset
branch
from
dac6b1b to
696957f
Compare
Contributor
Author
|
Hi @lafrenierejm - This has been waiting on reviews for ~6 months. Is there anything I can do to help steward this along to get it reviewed, merged, and released? |
Contributor
Author
|
Hi @kfcampbell - I believe you've merged/released other PRs. Is there anything I can do to help steward this along to get it reviewed, merged, and released? Thanks! |
1 task
mdb
force-pushed
the
mdb/gh-release-asset
branch
from
5ba605e to
0671ab4
Compare
Contributor
Author
Contributor
|
Hey @mdb 👋 Thanks for the contribution! The changes look good for the most part.
|
mdb
force-pushed
the
mdb/gh-release-asset
branch
from
0671ab4 to
9b364b5
Compare
This addresses issue integrations#2513 and adds support for a `github_release_asset` data source. Example of passing acceptance tests: ``` GITHUB_ORGANIZATION=mterwill \ GITHUB_OWNER=mterwill \ TF_ACC=1 \ go test -v ./... -run ^TestAccGithubReleaseAssetDataSource ? github.com/integrations/terraform-provider-github/v6 [no test files] === RUN TestAccGithubReleaseAssetDataSource === RUN TestAccGithubReleaseAssetDataSource/queries_specified_asset_ID === RUN TestAccGithubReleaseAssetDataSource/queries_specified_asset_ID/with_an_anonymous_account provider_utils.go:51: GITHUB_TOKEN environment variable should be empty provider_utils.go:74: Skipping TestAccGithubReleaseAssetDataSource/queries_specified_asset_ID/with_an_anonymous_account which requires anonymous mode === RUN TestAccGithubReleaseAssetDataSource/queries_specified_asset_ID/with_an_individual_account === RUN TestAccGithubReleaseAssetDataSource/queries_specified_asset_ID/with_an_organization_account --- PASS: TestAccGithubReleaseAssetDataSource (11.65s) --- PASS: TestAccGithubReleaseAssetDataSource/queries_specified_asset_ID (11.65s) --- SKIP: TestAccGithubReleaseAssetDataSource/queries_specified_asset_ID/with_an_anonymous_account (0.00s) --- PASS: TestAccGithubReleaseAssetDataSource/queries_specified_asset_ID/with_an_individual_account (8.90s) --- PASS: TestAccGithubReleaseAssetDataSource/queries_specified_asset_ID/with_an_organization_account (2.75s) PASS ok github.com/integrations/terraform-provider-github/v6/github 12.434s ``` Signed-off-by: Mike Ball <mikedball@gmail.com>
mdb
force-pushed
the
mdb/gh-release-asset
branch
from
9b364b5 to
2407ae3
Compare
Per request of @deiga (integrations#2514 (comment)), this adds tests for previewHeaderInjectorTransport.RoundTrip logic around application/octest-stream header handling. See google/go-github#3392 for context. Signed-off-by: Mike Ball <mikedball@gmail.com>
Contributor
Author
|
Thanks for the quick response @deiga !
I've added a comment linking to corresponding context over in google/go-github#3392 (and note that this is fixed in go-github/v68 (Admittedly, this is all a bit foggy for me -- it's been over a year since I opened this PR as well as since I opened google/go-github#3392)).
I added unit tests. Does that address your concern?
Done!
Done! |
Contributor
Author
|
@deiga 👋 Gentle nudge! Have I addressed your concerns in the response above? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #2513 and adds support for a
github_release_assetdata source.Example of passing acceptance tests:
Resolves #2513
Before the change?
github_release_assetdata sourceAfter the change?
github_release_assetdata sourcePull request checklist
Does this introduce a breaking change?
No.
Please see our docs on breaking changes to help!