fix(github_repository_file): Commit detail changes should not do empty commits #2643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e__fix-empty-commits # Conflicts: # github/resource_github_repository_file.go
The Update and Delete functions were dereferencing opts.Message without checking for nil, which could cause a panic when users don't specify a commit_message in their configuration. Added nil checks before dereferencing to use default messages when no custom message is provided.
Author
|
@nickfloyd Hey, this PR was outdated due to being open for several months, so I just updated it with the latest main and resolved all conflicts. Could you review it when you get a chance? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When terraform changes any field related to how commits are done (email, commit message, etc), it pushes an unexpected empty commit to the repo.
This is specially relevant when importing an existing file into terraform, where the commit message you put in terraform will likely be different from the commit that pushed the file originally. In that sense, importing a file will always mean eventually doing empty commits for each file you imported.
The expected behaviour is just updating the state and avoid doing those empty commits. Otherwise, each empty commit can run any CI that might be configured, notifications, etc.
Resolves #689
Recreated from #2638
Before the change?
commit_sha,commit_author,commit_emailorcommit_messagechanged, it did a empty commitAfter the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!