Skip to content

feat(actions_permissions): sha_pinning_required #2870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sheeeng wants to merge 4 commits into
base: main
Choose a base branch
from
+26 −2
Open

feat(actions_permissions): sha_pinning_required #2870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1bbc69f
feat(actions_permissions): sha_pinning_required
sheeeng Dec 1, 2025
6d700ff
feat(actions_permissions): sha_pinning_required
sheeeng Jan 9, 2026
2c47467
feat(actions_permissions): sha_pinning_required
sheeeng Jan 9, 2026
9e57d44
Merge branch 'main' into feat/actions_permissions_sha_pinning_required
nickfloyd Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions github/resource_github_actions_organization_permissions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,11 @@
Optional: true,
Description: "Whether actions in GitHub Marketplace from verified creators are allowed. Set to 'true' to allow all GitHub Marketplace actions by verified creators.",
},
"sha_pinning_required": {
Type: schema.TypeBool,
Optional: true,
Description: "Whether pinning to a specific SHA is required for all actions and reusable workflows in an organization.",
},
Comment on lines +60 to +64
Copy link
Contributor

@deiga deiga Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: This field should be moved to top-level. It's not part of the allowed_actions_config

},
},
},
Expand Down Expand Up @@ -96,6 +101,10 @@
allowed.VerifiedAllowed = &x
}

if v, ok := data["sha_pinning_required"]; ok {
allowed.SHAPinningRequired = github.Ptr(v.(bool))

Check failure on line 105 in github/resource_github_actions_organization_permissions.go

View workflow job for this annotation

GitHub Actions / Continuous Integration 

allowed.SHAPinningRequired undefined (type *"github.com/google/go-github/v81/github".ActionsAllowed has no field or method SHAPinningRequired)

Check failure on line 105 in github/resource_github_actions_organization_permissions.go

View workflow job for this annotation

GitHub Actions / Analyze (go) 

allowed.SHAPinningRequired undefined (type *"github.com/google/go-github/v81/github".ActionsAllowed has no field or method SHAPinningRequired)
Copy link
Contributor

@deiga deiga Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: SHAPinningRequired is not a field in ActionsAllowed but ActionsPermissions, you need to move where this is set

}

patternsAllowed := []string{}

switch t := data["patterns_allowed"].(type) {
Expand Down Expand Up @@ -226,6 +235,7 @@
"github_owned_allowed": actionsAllowed.GetGithubOwnedAllowed(),
"patterns_allowed": actionsAllowed.PatternsAllowed,
"verified_allowed": actionsAllowed.GetVerifiedAllowed(),
"sha_pinning_required": actionsAllowed.GetShaPinningRequired(),

Check failure on line 238 in github/resource_github_actions_organization_permissions.go

View workflow job for this annotation

GitHub Actions / Continuous Integration 

actionsAllowed.GetShaPinningRequired undefined (type *"github.com/google/go-github/v81/github".ActionsAllowed has no field or method GetShaPinningRequired)

Check failure on line 238 in github/resource_github_actions_organization_permissions.go

View workflow job for this annotation

GitHub Actions / Analyze (go) 

actionsAllowed.GetShaPinningRequired undefined (type *"github.com/google/go-github/v81/github".ActionsAllowed has no field or method GetShaPinningRequired)
},
}); err != nil {
return err
Expand Down
4 changes: 3 additions & 1 deletion github/resource_github_actions_organization_permissions_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ func TestAccGithubActionsOrganizationPermissions(t *testing.T) {
enabledRepositories := "selected"
githubOwnedAllowed := true
verifiedAllowed := true
shaPinningRequired := true
randomID := acctest.RandStringFromCharSet(5, acctest.CharSetAlphaNum)

config := fmt.Sprintf(`
Expand All @@ -62,12 +63,13 @@ func TestAccGithubActionsOrganizationPermissions(t *testing.T) {
github_owned_allowed = %t
patterns_allowed = ["actions/cache@*", "actions/checkout@*"]
verified_allowed = %t
sha_pinning_required = %t
}
enabled_repositories_config {
repository_ids = [github_repository.test.repo_id]
}
}
`, randomID, allowedActions, enabledRepositories, githubOwnedAllowed, verifiedAllowed)
`, randomID, allowedActions, enabledRepositories, githubOwnedAllowed, verifiedAllowed, shaPinningRequired)

check := resource.ComposeTestCheckFunc(
resource.TestCheckResourceAttr(
Expand Down
10 changes: 10 additions & 0 deletions github/resource_github_actions_repository_permissions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,11 @@
Optional: true,
Description: "Whether actions in GitHub Marketplace from verified creators are allowed. Set to 'true' to allow all GitHub Marketplace actions by verified creators.",
},
"sha_pinning_required": {
Type: schema.TypeBool,
Optional: true,
Description: "Whether pinning to a specific SHA is required for all actions and reusable workflows in a repository.",
},
},
},
},
Expand Down Expand Up @@ -85,6 +90,10 @@
allowed.VerifiedAllowed = &x
}

if v, ok := data["sha_pinning_required"]; ok {
allowed.SHAPinningRequired = github.Ptr(v.(bool))

Check failure on line 94 in github/resource_github_actions_repository_permissions.go

View workflow job for this annotation

GitHub Actions / Continuous Integration 

allowed.SHAPinningRequired undefined (type *"github.com/google/go-github/v81/github".ActionsAllowed has no field or method SHAPinningRequired)

Check failure on line 94 in github/resource_github_actions_repository_permissions.go

View workflow job for this annotation

GitHub Actions / Analyze (go) 

allowed.SHAPinningRequired undefined (type *"github.com/google/go-github/v81/github".ActionsAllowed has no field or method SHAPinningRequired)
}

patternsAllowed := []string{}

switch t := data["patterns_allowed"].(type) {
Expand Down Expand Up @@ -189,6 +198,7 @@
"github_owned_allowed": actionsAllowed.GetGithubOwnedAllowed(),
"patterns_allowed": actionsAllowed.PatternsAllowed,
"verified_allowed": actionsAllowed.GetVerifiedAllowed(),
"sha_pinning_required": actionsAllowed.GetShaPinningRequired(),

Check failure on line 201 in github/resource_github_actions_repository_permissions.go

View workflow job for this annotation

GitHub Actions / Continuous Integration 

actionsAllowed.GetShaPinningRequired undefined (type *"github.com/google/go-github/v81/github".ActionsAllowed has no field or method GetShaPinningRequired)) (typecheck)

Check failure on line 201 in github/resource_github_actions_repository_permissions.go

View workflow job for this annotation

GitHub Actions / Analyze (go) 

actionsAllowed.GetShaPinningRequired undefined (type *"github.com/google/go-github/v81/github".ActionsAllowed has no field or method GetShaPinningRequired)
},
}); err != nil {
return err
Expand Down
4 changes: 3 additions & 1 deletion github/resource_github_actions_repository_permissions_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ func TestAccGithubActionsRepositoryPermissions(t *testing.T) {
allowedActions := "selected"
githubOwnedAllowed := true
verifiedAllowed := true
shaPinningRequired := true
randomID := acctest.RandStringFromCharSet(5, acctest.CharSetAlphaNum)

config := fmt.Sprintf(`
Expand All @@ -63,10 +64,11 @@ func TestAccGithubActionsRepositoryPermissions(t *testing.T) {
github_owned_allowed = %t
patterns_allowed = ["actions/cache@*", "actions/checkout@*"]
verified_allowed = %t
sha_pinning_required = %t
}
repository = github_repository.test.name
}
`, randomID, allowedActions, githubOwnedAllowed, verifiedAllowed)
`, randomID, allowedActions, githubOwnedAllowed, verifiedAllowed, shaPinningRequired)

check := resource.ComposeTestCheckFunc(
resource.TestCheckResourceAttr(
Expand Down
Loading