Skip to content

Conversation

@ViacheslavKudinov
Copy link
Contributor

@ViacheslavKudinov ViacheslavKudinov commented Dec 8, 2025

Resolves #ISSUE_NUMBER


Before the change?

  • Release notes do not have the link to attestation URL

After the change?

  • ✅ The release notes include the link to attestation URL and commands how to download and verify release artifacts

Example: https://github.com/vk-or/terraform-provider-github/releases/tag/v0.0.18

Pull request checklist

  • Schema migrations have been created if needed (example)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@github-actions
Copy link

github-actions bot commented Dec 8, 2025

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@github-actions github-actions bot added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Dec 8, 2025
Signed-off-by: Viacheslav Kudinov <viacheslav@kudinov.tech>
@ViacheslavKudinov ViacheslavKudinov force-pushed the maintenance/add-attestation-on-release-notes branch from b3823bf to 3580ffc Compare December 8, 2025 12:14
@ViacheslavKudinov ViacheslavKudinov changed the title Maintenance/add attestation on release notes chore(actions): Add attestation URL, download and verify commands on release notes Dec 8, 2025
@ViacheslavKudinov ViacheslavKudinov marked this pull request as ready for review December 8, 2025 14:02
@ViacheslavKudinov
Copy link
Contributor Author

Hi @nickfloyd
feel free to add into relevant milestone.

Copy link
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pattern means that release notifications wont contain the attestation text as it's appended after the release. My suggestion would either be to link to docs on how to validate or to use custom release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants