Skip to content

Conversation

@deiga
Copy link
Contributor

@deiga deiga commented Jan 7, 2026

Supersedes #3035


Before the change?

  • Repository names in tests didn't follow a standard pattern
  • Team names in tests didn't follow a standard pattern
  • Repository sweeper didn't actually work

After the change?

  • Repository and Team names in tests use testResourcePrefix to ensure that sweepers can be used
  • Added make target for sweep

Pull request checklist

  • Schema migrations have been created if needed (example)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@github-actions
Copy link

github-actions bot commented Jan 7, 2026

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@deiga deiga changed the title [MAINT] Align team and repo names in tests [MAINT] Properly enable test sweeper Jan 7, 2026
deiga added 7 commits January 7, 2026 23:10
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
…ady has secrets

Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@deiga deiga force-pushed the align-team-and-repo-names-in-tests branch from 85fdd6f to 748adbd Compare January 7, 2026 21:21
Copy link
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finishing this work off, I was planning on finishing it as part of the acceptance tests work before Christmas but never got round to doing all of the plumbing.

Do you have a way to catch new tests added since you last rebased from main?

@stevehipwell stevehipwell added this to the v6.10.0 Release milestone Jan 8, 2026
@stevehipwell stevehipwell added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jan 8, 2026
@deiga
Copy link
Contributor Author

deiga commented Jan 8, 2026

@stevehipwell Unfortunately, I don't :/

  • One option could be to create a custom linter for golangci-lint, but I don't know how involved that would be.
  • Another that comes to mind, would be to create a Builder-pattern for repo and team resources, but that falls short quickly

One very simplistic check could be to run something like grep 'name\s+=\s+%s' -v *_test.go 😬

@stevehipwell
Copy link
Collaborator

@deiga I was really thinking about keeping the PR valid before it's merged. Once it's in the code we'll just need to be good at reviewing. Custom linters are powerful, but the UX for contributors isn't great.

@deiga
Copy link
Contributor Author

deiga commented Jan 8, 2026

Ah, right. I was already thinking structural :D

@stevehipwell
Copy link
Collaborator

@deiga if you get this ready to merge, we could look to get it prioritised so the burden lands on the new PRs (I know this pain from the tests PR)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants