-
Notifications
You must be signed in to change notification settings - Fork 913
[MAINT] Properly enable test sweeper #3055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[MAINT] Properly enable test sweeper #3055
Conversation
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
…ady has secrets Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
85fdd6f to
748adbd
Compare
stevehipwell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finishing this work off, I was planning on finishing it as part of the acceptance tests work before Christmas but never got round to doing all of the plumbing.
Do you have a way to catch new tests added since you last rebased from main?
|
@stevehipwell Unfortunately, I don't :/
One very simplistic check could be to run something like |
|
@deiga I was really thinking about keeping the PR valid before it's merged. Once it's in the code we'll just need to be good at reviewing. Custom linters are powerful, but the UX for contributors isn't great. |
|
Ah, right. I was already thinking structural :D |
|
@deiga if you get this ready to merge, we could look to get it prioritised so the burden lands on the new PRs (I know this pain from the tests PR)? |
Supersedes #3035
Before the change?
After the change?
testResourcePrefixto ensure that sweepers can be usedPull request checklist
Schema migrations have been created if needed (example)Docs have been reviewed and added / updated if needed (for bug fixes / features)Does this introduce a breaking change?
Please see our docs on breaking changes to help!