fix: Correct private forking implementation #3067
Conversation
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
stevehipwell
force-pushed
the
fix-private-forking
branch
2 times, most recently
from
af34d15 to
f1ef955
Compare
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
stevehipwell
force-pushed
the
fix-private-forking
branch
from
f1ef955 to
c5133e4
Compare
| "allow_forking": { | ||
| Type: schema.TypeBool, | ||
| Optional: true, | ||
| Default: false, |
There was a problem hiding this comment.
Why was this default value changed? It's not backwards compatible.
There was a problem hiding this comment.
@lebenitza how can this change not be backwards compatible when the allow_forking wasn't released until after this follow up PR was merged?
4 participants
Fixes issue introduced with #3056
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!