[FEAT] Add new resource for repository vulnerability alerts#3166
[FEAT] Add new resource for repository vulnerability alerts#3166deiga wants to merge 9 commits intointegrations:mainfrom
Conversation
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
deiga
force-pushed
the
add-github_repository_vulnerability_alerts
branch
2 times, most recently
from
fb54b9b to
5b5d40c
Compare
stevehipwell
left a comment
stevehipwell
left a comment
There was a problem hiding this comment.
This is looking good.
deiga
force-pushed
the
add-github_repository_vulnerability_alerts
branch
from
5b5d40c to
8ba3a26
Compare
|
|
||
| func resourceGithubRepositoryVulnerabilityAlertsImport(ctx context.Context, d *schema.ResourceData, m any) ([]*schema.ResourceData, error) { | ||
| tflog.Debug(ctx, "Importing repository vulnerability alerts", map[string]any{"id": d.Id()}) | ||
| repoOwner, repoName, err := parseID2(d.Id()) |
There was a problem hiding this comment.
We only need to use the repo ID here as we can use the GetByID() function that will also return the owner which we can check against meta.name until we support defining the owner.
There was a problem hiding this comment.
Yes, but I don't like asking folks to use repo ID as the import ID, since it's not findable in the GH UI AFAIK
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
deiga
force-pushed
the
add-github_repository_vulnerability_alerts
branch
from
8ba3a26 to
7ea9d1a
Compare
2 participants
Resolves #3038
Before the change?
github_repositoryresource.After the change?
vulnerability_alertsin thegithub_repositoryresource are marked as deprecatedPull request checklist
Schema migrations have been created if needed (example)Does this introduce a breaking change?
Please see our docs on breaking changes to help!