Bugfix: tokenFromGHCLI not stripping api. from ghe.com hosts. Resolves #3188#3190
Open
clawster wants to merge 6 commits intointegrations:mainfrom
Open
Bugfix: tokenFromGHCLI not stripping api. from ghe.com hosts. Resolves #3188#3190clawster wants to merge 6 commits intointegrations:mainfrom
clawster wants to merge 6 commits intointegrations:mainfrom
Conversation
tokenFromGHCLI only mapped api.github.com → github.com before calling `gh auth token --hostname`. For GHEC hosts (api.<slug>.ghe.com), the api. prefix was not stripped, causing the CLI lookup to fail silently and the provider to fall back to an unauthenticated client (401 errors). Strip the api. prefix for GHEC hosts using the existing GHECAPIHostMatch regex so the hostname matches how `gh` stores credentials. Fixes integrations#3188
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
Author
|
Replaces PR#3189 (no changes, new fork) |
stevehipwell
requested changes
Feb 20, 2026
Collaborator
stevehipwell
left a comment
stevehipwell
left a comment
There was a problem hiding this comment.
Thanks for the PR @clawster, I've added a few comments.
- move hostname modification to separate function for easier testing - test omdified to only test ghCLIHostFromAPIHost() without OS specific scripts - line ending fixed
Author
|
Thanks for the review and suggestions, code updated |
Collaborator
|
@clawster could you please rebase? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugfix: tokenFromGHCLI not stripping api. from ghe.com hosts. Resolves #3188
Before the change?
tokenFromGHCLIonly mappedapi.github.com->github.combefore callinggh auth token --hostnameapi.<slug>.ghe.com), theapi.prefix was not stripped, causing the CLI lookup to fail silentlyAfter the change?
api.prefix for GHEC hosts using the existingGHECAPIHostMatchregexghCLI for GHEC (*.ghe.com) instancesgh auth login --hostname my-enterprise.ghe.comhas been completedPull request checklist
Does this introduce a breaking change?