Skip to content

make sure PMUs are not in use when running the metrics command #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harp-intel merged 2 commits into from
Jan 7, 2025
Merged

make sure PMUs are not in use when running the metrics command #144

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fab9ae0
make sure PMUs are not in use when running the metrics command
harp-intel Jan 7, 2025
0cec79c
only check for busy PMUs on Intel processors
harp-intel Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions cmd/metrics/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -806,6 +806,27 @@ func prepareTarget(targetContext *targetContext, targetTempRoot string, localTem
channelError <- targetError{target: myTarget, err: err}
return
}
// make sure PMUs are not in use on target
if family, err := myTarget.GetFamily(); err == nil && family == "6" {
output, err := script.RunScript(myTarget, script.GetScriptByName(script.PMUBusyScriptName), localTempDir)
if err != nil {
err = fmt.Errorf("failed to check if PMUs are in use: %w", err)
_ = statusUpdate(myTarget.GetName(), fmt.Sprintf("Error: %v", err))
targetContext.err = err
channelError <- targetError{target: myTarget, err: err}
return
}
for _, line := range strings.Split(output.Stdout, "\n") {
// if one of the MSR registers is active (ignore cpu_cycles), then the PMU is in use
if strings.Contains(line, "Active") && !strings.Contains(line, "0x30a") {
err = fmt.Errorf("PMU in use on target: %s", line)
_ = statusUpdate(myTarget.GetName(), fmt.Sprintf("Error: %v", err))
targetContext.err = err
channelError <- targetError{target: myTarget, err: err}
return
}
}
}
// check if NMI watchdog is enabled and disable it if necessary
if !flagNoRoot {
var nmiWatchdogEnabled bool
Expand Down
Loading