Skip to content

Conversation

@harp-intel
Copy link
Contributor

This pull request refactors how network-related data is organized and reported, mainly by removing the "Network IRQ Mapping" category and table, and by introducing a new "NIC CPU Affinity" table. Additionally, it moves the reporting of IRQ Balance to the network configuration section and cleans up related code and tests. These changes improve the clarity and separation of network metrics in the report.

Network Table and Flag Refactoring:

  • Removed the "Network IRQ Mapping" table and its associated flag and category, replacing it with a new "NIC CPU Affinity" table and updating the relevant flag and category mappings in report.go and table_defs.go. [1] [2] [3] [4] [5] [6]

NIC Table Structure and Data Cleanup:

  • Removed the "IRQBalance" field from the NIC table and its associated parsing logic, ensuring that this information is no longer collected or displayed in the NIC table. (F137e4b0L1637R1637, [1] [2] [3] [4]

Network Configuration Table Enhancement:

  • Added an "IRQ Balance" field to the network configuration table, and implemented a new script (irq balance) to determine if IRQ balancing is enabled, integrating its output into the report. [1] [2] [3] [4]

Script and Output Adjustments:

  • Updated the NIC info script to remove output related to IRQ Balance, as this is now handled by a separate script.

Label and Field Naming Improvements:

  • Improved naming for certain fields (e.g., "xps_cpus" → "XPS", "rps_cpus" → "RPS") for clarity in the NIC packet steering table.

These changes collectively clarify the distinction between NIC-specific and system-wide network settings, and make the report output more organized and maintainable.

Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
@harp-intel harp-intel requested a review from Copilot November 21, 2025 15:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request reorganizes network-related reporting by consolidating IRQ Balance information into the Network Configuration table and renaming the "Network IRQ Mapping" table to "NIC CPU Affinity". The main purpose is to improve clarity by distinguishing between system-wide network settings and NIC-specific configurations.

Key changes:

  • Moved IRQ Balance from NIC table to Network Configuration table as a system-wide setting
  • Renamed "Network IRQ Mapping" table to "NIC CPU Affinity" for better clarity
  • Improved field naming in NIC Packet Steering table (xps_cpus → XPS, rps_cpus → RPS)

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
internal/script/script_defs.go Added new IRQ Balance script and removed IRQ Balance output from NIC info script
internal/report/table_helpers_test.go Removed test assertion for IRQBalance field that no longer exists in NIC table
internal/report/table_helpers.go Removed IRQBalance field from nicInfo struct and parsing logic
internal/report/table_defs.go Reorganized table definitions, moved IRQ Balance to Network Config, renamed Network IRQ Mapping to NIC CPU Affinity, and improved packet steering field names
cmd/report/report.go Removed flagNetIrq flag and updated categories to reflect new table organization

harp-intel and others added 3 commits November 21, 2025 07:28
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
@harp-intel harp-intel merged commit b637efb into main Nov 22, 2025
5 checks passed
@harp-intel harp-intel deleted the nictables branch November 22, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants