fix: don't create output directory for commands that don't produce output #568
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors how and when the output directory is created in the application. The main improvement is to avoid creating the output directory for commands that do not generate output files, which helps prevent unnecessary filesystem operations and potential permission errors. Additionally, the
createOutputDirfunction was moved within the file for better organization.Logic improvements for output directory creation:
config,update, and certain modes of themetricscommand (such as when--live,--prometheus-server,--prometheus-server-addr, or--listflags are set), since these do not produce output files. [1] [2]Code organization:
createOutputDirfunction to a later position in the file for improved code organization and readability. [1] [2]