Skip to content

Conversation

@harp-intel
Copy link
Contributor

This pull request refactors how and when the output directory is created in the application. The main improvement is to avoid creating the output directory for commands that do not generate output files, which helps prevent unnecessary filesystem operations and potential permission errors. Additionally, the createOutputDir function was moved within the file for better organization.

Logic improvements for output directory creation:

  • Added logic to skip creating the output directory for the config, update, and certain modes of the metrics command (such as when --live, --prometheus-server, --prometheus-server-addr, or --list flags are set), since these do not produce output files. [1] [2]

Code organization:

  • Moved the createOutputDir function to a later position in the file for improved code organization and readability. [1] [2]

…tput

Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
@harp-intel harp-intel merged commit daa6d4d into main Nov 23, 2025
5 checks passed
@harp-intel harp-intel deleted the nooutputdir branch November 23, 2025 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants