move output dir creation decision to commands

[harp-intel]

This pull request refactors the logic for creating output directories, centralizing it for better maintainability and ensuring that directories are only created when necessary. The main changes include removing duplicate output directory creation logic from cmd/root.go, introducing a reusable helper function, and updating command handlers to use this new approach.

Refactoring output directory creation logic:

• Removed the custom output directory creation logic from cmd/root.go, including the createOutputDir function and related conditional checks, to avoid duplication and simplify command initialization. [1] [2]
• Added a new helper function needsOutputDir in cmd/metrics/metrics.go to determine when the output directory should be created, based on command flags and mode.
• Updated the runCmd function in cmd/metrics/metrics.go to use needsOutputDir and create the output directory only when required, improving error handling and user feedback.

Applying centralized directory creation in reporting commands:

• Updated internal/common/common.go to create the output directory at the start of the ReportingCommand.Run method, using the shared utility function for consistency and error handling.

Minor code correctness fix:

• Fixed variable assignment in ReportingCommand.Run to use the existing rawReports variable, preventing shadowing and potential bugs.

[Copilot]

Pull request overview

This PR refactors output directory creation logic by moving it from the root command initialization to individual command handlers. The changes eliminate duplicate code, ensure directories are created only when necessary, and improve error handling consistency.

Key changes:

• Removed centralized output directory creation logic from cmd/root.go that attempted to predict which commands need output directories
• Added command-specific directory creation in cmd/metrics/metrics.go and internal/common/common.go where output is actually generated
• Fixed a variable shadowing bug in internal/common/common.go

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
cmd/root.go	Removed the createOutputDir function and preemptive directory creation logic from application initialization
cmd/metrics/metrics.go	Added needsOutputDir helper function and directory creation at the start of runCmd
internal/common/common.go	Added directory creation at the start of ReportingCommand.Run and fixed variable shadowing issue