Catch up with latest 'modernize' suggestions and remove 'modernize' from the list of checkers required to pass #587
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on modernizing string construction throughout the codebase by replacing string concatenation with the more efficient
strings.Builderand by usingfmt.Fprintfinstead offmt.Sprintffor building strings. These changes improve performance and code clarity, especially in sections that generate large or complex strings such as reports, scripts, and table renderers. Additionally, a minor update was made to theMakefileto adjust thechecktarget dependencies.String construction modernization:
strings.Builderand usedfmt.Fprintfinstead offmt.Sprintffor building strings in various locations, including table renderers, report generators, script builders, and telemetry functions. This affects files such ascmd/config/config_tables.go,cmd/config/restore.go,cmd/config/set.go,cmd/metrics/perf_mux.go,cmd/flame/flame_tables.go,cmd/telemetry/telemetry_tables.go, and multiple report rendering functions ininternal/report/render_html.goandinternal/report/render_text.go. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15]Build process update:
check_modernizedependency from thechecktarget in theMakefile, streamlining the default check process.