run all scripts with controller #596
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors how scripts are executed and managed, replacing the previous parallel execution model with a unified "controller" script approach. It also updates terminology throughout the codebase to use "concurrent" instead of "parallel" for clarity. Additionally, it improves signal handling to ensure robust cleanup of script processes.
Key changes include:
Script Execution Refactor:
internal/script/script.go,internal/common/common.go). [1] [2] [3]ControllerPIDFileNameconstant and updates references to use "controller.pid" for process tracking instead of the previous "primary_collection_script.pid". [1] [2]Signal Handling Improvements:
signalProcessOnTargetto abstract sending signals, and improves timeout/cleanup logic to escalate from SIGINT to SIGKILL if needed. [1] [2] [3]Terminology and Documentation Updates:
These changes collectively streamline script execution and improve reliability, especially in signal handling and process cleanup scenarios.