Implement privilege checks and skip targets with no collectable data #604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements enhanced privilege and target applicability checks to improve the workflow efficiency. The changes add stricter privilege validation and skip targets that have no collectable data, preventing unnecessary processing overhead.
Key changes:
- Added utility functions for checking privilege requirements and counting applicable tables per target
- Implemented early target filtering to skip targets with no collectable data
- Refactored privilege checking logic for better code organization
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/workflow/workflow.go | Added logic to filter out targets with zero applicable tables before data collection |
| internal/workflow/collection.go | Refactored privilege checking with new utility functions and added privilege-based filtering in isTableForTarget |
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
The refactored function was using tableRequiresElevatedPrivileges which checks if ALL scripts require superuser. This changed the semantics from "any script needs elevation" to "any table has all scripts needing elevation". - Restored the original logic in elevatedPrivilegesRequired to check if ANY script requires superuser - Renamed tableRequiresElevatedPrivileges to allTableScriptsRequireSuperuser for clarity about its behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the logic for determining which targets are eligible for data collection, particularly focusing on privilege requirements and table applicability. The main changes ensure that targets which cannot run all required scripts due to privilege constraints are skipped, and only relevant targets are processed.
Eligibility and filtering logic improvements:
isTableForTargetto skip tables where all scripts require superuser privileges if the target cannot elevate privileges.allTableScriptsRequireSuperuserto determine if every script in a table requires superuser privileges.numTablesForTargetto count how many tables are applicable for a given target, used for filtering.Runmethod inReportingCommandto remove targets with no applicable tables, providing a status update for skipped targets.