Skip to content

fix: elevate privileges for kernel module installation and uninstallation #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harp-intel merged 1 commit into from
Jan 6, 2026
Merged

fix: elevate privileges for kernel module installation and uninstallation #605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions internal/target/helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,13 @@ func installLkms(t Target, lkms []string) (installedLkms []string, err error) {
}
for _, lkm := range lkms {
slog.Debug("attempting to install kernel module", slog.String("lkm", lkm))
_, _, _, err := t.RunCommandEx(exec.Command("modprobe", "--first-time", lkm), 10, false, true) // #nosec G204
var cmd *exec.Cmd
if !t.IsSuperUser() {
cmd = exec.Command("sudo", "modprobe", "--first-time", lkm)
} else {
cmd = exec.Command("modprobe", "--first-time", lkm)
}
_, _, _, err := t.RunCommandEx(cmd, 10, false, true) // #nosec G204
if err != nil {
slog.Debug("kernel module already installed or problem installing", slog.String("lkm", lkm), slog.String("error", err.Error()))
continue
Expand Down Expand Up @@ -61,7 +67,13 @@ func uninstallLkms(t Target, lkms []string) (err error) {
}
for _, lkm := range lkms {
slog.Debug("attempting to uninstall kernel module", slog.String("lkm", lkm))
_, _, _, err := t.RunCommandEx(exec.Command("modprobe", "-r", lkm), 10, false, true) // #nosec G204
var cmd *exec.Cmd
if !t.IsSuperUser() {
cmd = exec.Command("sudo", "modprobe", "-r", lkm)
} else {
cmd = exec.Command("modprobe", "-r", lkm)
}
_, _, _, err := t.RunCommandEx(cmd, 10, false, true) // #nosec G204
if err != nil {
slog.Error("error uninstalling kernel module", slog.String("lkm", lkm), slog.String("error", err.Error()))
continue
Expand Down