Fix folders and urls in Postman collection generation #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
steve-henry
commented
Apr 25, 2025
steve-henry
commented
- Updated how the Postman endpoints are grouped based on tags in the OpenAPI spec
- Set the URL for all requests to include the production base url
- Ran the generation to update the existing Postman collections
VarshSuresh
reviewed
Apr 25, 2025
| protocol: 'https', | ||
| host: server.host || server.hostname, | ||
| path: this.path(server, path), | ||
| host: ['api.intercom.io'], |
Contributor
There was a problem hiding this comment.
Non blocking:
Sorry my knowledge on this is low. But do we just generate postman collections only for the US region?
Contributor
Author
There was a problem hiding this comment.
Ah, we could generate a different environment for each region and insert the base url as a variable. That would be a good follow up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.