Skip to content

Conversation

@marcmlc
Copy link
Contributor

@marcmlc marcmlc commented Aug 14, 2025

Summary

This PR updates the OpenAPI specification to align with changes from https://github.com/intercom/developer-docs/pull/597

🤖 Generated with Claude Code

This change introduces granular activity types for admin assignment limit changes,
allowing developers to distinguish between conversation and ticket assignment limits.

Changes:
- Split `admin_assignment_limit_change` into two separate activity types:
  - `admin_conversation_assignment_limit_change`
  - `admin_ticket_assignment_limit_change`
- Added new metadata fields to activity_log_metadata:
  - `conversation_assignment_limit`
  - `ticket_assignment_limit`

This is a follow-up to intercom/developer-docs#597

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@marcmlc marcmlc merged commit 8f22f8a into main Aug 14, 2025
6 checks passed
@marcmlc marcmlc deleted the marcmeillac/admin-activity-logs-assignment-limits branch August 14, 2025 14:59
salmanbshah added a commit that referenced this pull request Nov 6, 2025
Adds OpenAPI documentation for team assignment limit changes in activity logs API.

Changes:
- Adds team_assignment_limit_change to activity_type enum
- Adds team (object with id and name) metadata field
- Adds old_assignment_limit (nullable integer) metadata field
- Adds new_assignment_limit (nullable integer) metadata field

Related PRs:
- intercom/intercom#445742 (API presenter implementation)
- intercom/intercom#445704 (Event infrastructure)

Related Issue: intercom/intercom#445916

Follows pattern from PR #293 (admin assignment limits).
salmanbshah added a commit that referenced this pull request Nov 10, 2025
Adds OpenAPI documentation for team assignment limit changes in activity logs API.

Changes:
- Adds team_assignment_limit_change to activity_type enum in both Unstable (0) and Stable (2.14)
- Adds team (object with id and name) metadata field
- Adds old_assignment_limit (nullable integer) metadata field
- Adds new_assignment_limit (nullable integer) metadata field

This is an additive, non-breaking change suitable for the stable version.

Related PRs:
- intercom/intercom#445742 (API presenter implementation)
- intercom/intercom#445704 (Event infrastructure)

Related Issue: intercom/intercom#445916

Follows pattern from PR #293 (admin assignment limits).
salmanbshah added a commit that referenced this pull request Nov 10, 2025
Adds OpenAPI documentation for team assignment limit changes in activity logs API.

Changes:
- Adds team_assignment_limit_change to activity_type enum in both Unstable (0) and Stable (2.14)
- Adds team (object with id and name) metadata field
- Adds team_assignment_limit (nullable integer) metadata field

The metadata structure follows the pattern of conversation_assignment_limit and ticket_assignment_limit,
storing only the current value rather than both old and new values.

This is an additive, non-breaking change suitable for the stable version.

Related PRs:
- intercom/intercom#446612 (Updated API presenter implementation)
- intercom/intercom#445742 (Initial API presenter implementation)
- intercom/intercom#445704 (Event infrastructure)

Related Issue: intercom/intercom#445916

Follows pattern from PR #293 (admin assignment limits).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants