Refactor: Replace ConfigSingleton with direct instance variables#371
Closed
italomatos wants to merge 1 commit intointercom:masterfrom
Closed
Refactor: Replace ConfigSingleton with direct instance variables#371italomatos wants to merge 1 commit intointercom:masterfrom
italomatos wants to merge 1 commit intointercom:masterfrom
Conversation
Remove custom ConfigSingleton implementation that was causing ActiveSupport::Configurable deprecation warnings in Rails 8.2+. Changes: - Remove ConfigSingleton base class and its metaprogramming - Implement config_accessor using direct instance variable access - Convert config_group pattern to explicit nested classes - Maintain all existing validators and validation logic - Preserve public API compatibility - Update method syntax from blocks to keyword arguments All configuration behavior remains the same, but without relying on deprecated ActiveSupport::Configurable patterns.
italomatos
force-pushed
the
fix/remove-activesupport-configurable-deprecation
branch
from
8af48b2 to
5b1fc43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove custom ConfigSingleton implementation that was causing ActiveSupport::Configurable deprecation warnings in Rails 8.2+.
Changes:
All configuration behavior remains the same, but without relying on deprecated ActiveSupport::Configurable patterns.