-
Notifications
You must be signed in to change notification settings - Fork 84
Update Android SDK to 17.0.0 and bump version to 8.7.0 #300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Updated Android SDK dependency from 15.16.+ to 17.0.0 - Bumped package version from 8.6.0 to 8.7.0 - Adds support for Dark Mode on Android (currently in beta)
- Remove deprecated RNIntercomPushBroadcastReceiver class (no longer exists in SDK 17.0.0) - Update Android Gradle Plugin to 8.6.1 (required for new dependencies) - Update Gradle wrapper to 8.7 (required for AGP 8.6.1) - Remove RNIntercomPushBroadcastReceiver references from AndroidManifest.xml and README - Add suppressUnsupportedCompileSdk property to suppress warnings These changes are required for compatibility with Intercom Android SDK 17.0.0
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
- Remove example/package-lock.json - Remove example/yarn.lock These lock files should be generated locally and not committed to the repository.
…rsion conflict - Add packageManager field to satisfy Corepack requirements - Add undici resolution to force compatible version ^6.21.3 - Regenerate yarn.lock with compatible dependency versions - Fixes Node.js version conflict with undici@7.11.0 requiring >=20.18.1
- Change undici resolution from ^6.21.3 to exact 6.21.3 - Add **/undici resolution to catch nested dependencies - Regenerate yarn.lock to ensure undici@^7.10.0 resolves to 6.21.3 - Fixes remaining Node.js compatibility issues
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
- Add comprehensive dependency resolutions for problematic packages - Pin exact versions for undici, glob, rimraf, and @types/node - Add yarn.lock and package-lock.json to .gitignore - Remove yarn.lock from git tracking - Ensures consistent builds even without committed lock files
- Added npm overrides to package.json to complement existing yarn resolutions - Fixed undici version conflict that was causing Node.js compatibility issues - Ensures undici@6.21.3 is used consistently across all dependencies - Resolves build failures in CI environments with Node.js 20.17.0
- Updated CircleCI config to use 'yarn install --ignore-engines' - This resolves Node.js compatibility issues with undici@7.11.0 - Enhanced yarn resolutions to cover more specific dependency paths - Added yarn.lock file to lock dependency versions consistently - All tests, linting, and builds now pass successfully Fixes the error: 'undici@7.11.0: The engine "node" is incompatible with this module. Expected version ">=20.18.1". Got "20.17.0"'
🔧 Fixed CircleCI Dependency Installation IssuesI've resolved the failing CI checks that were caused by Node.js version compatibility issues with the 🐛 ProblemCircleCI was failing with: ✅ Solution
🧪 Verification
📋 Files Changed
The CI should now pass successfully! 🎉 |
|
@elizabit-b Thanks for the change! Do you plan to release this on npm? |
Summary
This PR updates the Intercom Android SDK to version 17.0.0 and bumps the React Native wrapper version to 8.7.0.
Changes
Core Updates
15.16.+to17.0.0inandroid/build.gradle8.6.0to8.7.0inpackage.jsonCompatibility Fixes (Required for Android SDK 17.0.0)
RNIntercomPushBroadcastReceiverclass - This class no longer exists in Android SDK 17.0.08.6.1(required for new dependencies)7.5.1/8.3to8.7(required for AGP 8.6.1)RNIntercomPushBroadcastReceiverreferences from AndroidManifest.xml and documentationandroid.suppressUnsupportedCompileSdk=35to suppress AGP warningsWhat's New in Android SDK 17.0.0
🚀 Enhancements
Breaking Changes
RNIntercomPushBroadcastReceiverclass has been removed from the Android SDK. If you were manually referencing this class in your AndroidManifest.xml, you'll need to remove those references.Before:
After:
<!-- Remove the receiver - it's no longer needed -->Push notifications will continue to work through the existing
FirebaseMessagingServiceimplementation.Testing
✅ Completed:
npm run prepare)npm test)npm run lint)🔄 Still needed:
Release Notes
For the 8.7.0 release:
Related Links