Skip to content

fix: resolve React Native codegen compatibility issues #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonpraful merged 1 commit into from
Sep 10, 2025
Merged

fix: resolve React Native codegen compatibility issues #322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ios/IntercomModule.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#import <React/RCTBridgeModule.h>

#ifdef RCT_NEW_ARCH_ENABLED
#import "IntercomReactNativeSpec.h"
#import <IntercomReactNativeSpec/IntercomReactNativeSpec.h>
@interface IntercomModule : NSObject <NativeIntercomSpecSpec>
#else
@interface IntercomModule : NSObject <RCTBridgeModule>
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@intercom/intercom-react-native",
"version": "9.0.2",
"version": "9.0.3",
"description": "React Native wrapper to bridge our iOS and Android SDK",
"source": "./src/index.tsx",
"main": "./lib/commonjs/index.js",
Expand Down
11 changes: 3 additions & 8 deletions src/NativeIntercomSpec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@ import { TurboModuleRegistry } from 'react-native';
export interface UserAttributes {
companies?: Array<{
createdAt?: number;
customAttributes?: { [key: string]: boolean | string | number };
customAttributes?: Object; // { [key: string]: boolean | string | number };
id: string;
monthlySpend?: number;
name?: string;
plan?: string;
}>;
customAttributes?: { [key: string]: boolean | string | number };
customAttributes?: Object; // { [key: string]: boolean | string | number };
email?: string;
languageOverride?: string;
name?: string;
Expand All @@ -21,12 +21,7 @@ export interface UserAttributes {
}

interface TurboModuleContent {
type:
| 'ARTICLE'
| 'CAROUSEL'
| 'SURVEY'
| 'HELP_CENTER_COLLECTIONS'
| 'CONVERSATION';
type: string; // ARTICLE, CAROUSEL, SURVEY, HELP_CENTER_COLLECTIONS, CONVERSATION
id?: string;
ids?: Array<string>;
}
Expand Down