add script to register asset #724
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
sander2
reviewed
Feb 9, 2024
| "target": "ES6", | ||
| "module": "ES6", | ||
| "outDir": "build/esm", | ||
| "module": "CommonJS", |
Member
There was a problem hiding this comment.
Does this not cause issues for the ui? Fwiw I had this
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -1,8 +1,15 @@
{
"extends": "./tsconfig-base.json",
+ "ts-node": {
+ // these options are overrides used only by ts-node
+ // same as the --compilerOptions flag and the TS_NODE_COMPILER_OPTIONS environment variable
+ "compilerOptions": {
+ "module": "commonjs"
+ }
+ },
Member
There was a problem hiding this comment.
I think my version is mergable but yea I guess we don't want the register-asset script
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scripts no longer compile so I has to tweak the
tsconfig.jsonto work with CommonJS so don't merge this.Use
ts-node scripts/register-asset.ts