feat: add handler for IssueAmountChange event #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theodorebugnet
suggested changes
Aug 15, 2022
Contributor
theodorebugnet
left a comment
theodorebugnet
left a comment
There was a problem hiding this comment.
Due to the schema change, a DB migration should be generated (see the relevant section in the README on updating the schema).
Otherwise all looks good
gregdhill
force-pushed
the
feat/issue-amount-change
branch
2 times, most recently
from
2984dd3 to
31ca9f4
Compare
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
gregdhill
force-pushed
the
feat/issue-amount-change
branch
from
31ca9f4 to
617853f
Compare
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gregory Hill gregorydhill@outlook.com
When a user sends more or less BTC to a Vault we update the execution amounts under-the-hood. To show in the UI what changed (and how much griefing collateral was slashed) we should capture the
IssueAmountChangeevent.