ravi/fix hover on cta #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for developers-preview pending review.Visit the deploys page to approve it
|
Contributor
|
I see the specificity issue is also effecting the hero link "Contribute on Github " which should also highlight to white. |
JoblersTune
reviewed
Jan 8, 2026
src/pages/index.astro
Outdated
| color: var(--color-white); | ||
| } | ||
|
|
||
| .hero__cta a:not(.btn):hover { |
Contributor
There was a problem hiding this comment.
I worry this style is not clean for maintainability. Let's rather add a class like hero__link and style it with that so we can see what element the styling is targeting more clearly.
JoblersTune
approved these changes
Jan 8, 2026
src/pages/index.astro
Outdated
| color: var(--color-white); | ||
| } | ||
|
|
||
| .hero__cta a:not(.btn):hover { |
Contributor
|
Thanks @Infi-Knight |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Fixes #123)bun run formatto ensure code is properly formattedbun run lintpasses without errorsSummary
Linear issue: https://linear.app/interledger/issue/DEVPORT-25/engineering-blog-cta-text-disappears-on-hover
The PR fixes the css so that the correct link colour is used on hover