Skip to content

Conversation

@Leo1305Pineda
Copy link
Contributor

Is require PR to this from PR #93
Resolved open rear camera from initial opening.

@Aarbel
Copy link

Aarbel commented Oct 27, 2021

@Leo1305Pineda can you write tests with your PR ?

Web RTC Camera is quite unstable on many environments, that would be great to not break it at every code update.

@Aarbel
Copy link

Aarbel commented Dec 15, 2021

@Leo1305Pineda do you plan to update your PR ?

@Leo1305Pineda
Copy link
Contributor Author

I have a build of this and it works fine for web, ios, and android.

@Aarbel
Copy link

Aarbel commented Dec 15, 2021

@Leo1305Pineda sure, we all have our custom fixes of web rtc camera, but would be really great to write a few tests to make it open-source friendly ;)

@Leo1305Pineda
Copy link
Contributor Author

Leo1305Pineda commented Dec 15, 2021

This PR is also required pwa-elements/pull/93)

@Aarbel
Copy link

Aarbel commented Dec 16, 2021

@Leo1305Pineda have you tested it on a Microsoft Surface device?

The devices API isn't standard (browser of Microsoft surface doesn't provide all the necessary metadata of devices).
So it may affect a lot of users if it doesn't work

@Leo1305Pineda
Copy link
Contributor Author

In pwa-elements there was no entry @prop () facesMode: FacingMode;
this was already applied in this PR pwa-elements/pull/93

@Aarbel
Copy link

Aarbel commented Dec 16, 2021

@Leo1305Pineda thanks a lot, don't hesitate to make a quick test anyway with Microsoft Surface, facingMode doesn't work well with these devices.

@jcesarmobile jcesarmobile changed the title fix camera rear fix(camera): set direction on web Dec 16, 2021
@jcesarmobile jcesarmobile merged commit 4afedb9 into ionic-team:main Dec 16, 2021
@jcesarmobile
Copy link
Member

Thanks for the pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants