feat(toggle): add helperText and errorText properties#30161
Merged
brandyscarney merged 15 commits intofeature-8.5from Mar 10, 2025
Merged
feat(toggle): add helperText and errorText properties#30161brandyscarney merged 15 commits intofeature-8.5from
brandyscarney merged 15 commits intofeature-8.5from
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
package: core
thetaPC
requested changes
Jan 31, 2025
Contributor
thetaPC
left a comment
thetaPC
left a comment
There was a problem hiding this comment.
The supporting text being read twice is the main issue.
The rest are just questions that were asked over in the checkbox PR that can be applied here.
BenOsodrac
requested changes
Feb 25, 2025
| // ---------------------------------------------------------------- | ||
|
|
||
| .toggle-bottom { | ||
| @include padding(4px, null, null, null); |
Contributor
There was a problem hiding this comment.
this should be on the native partial and on Ionic theme use the proper space token.
BenOsodrac
approved these changes
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
Toggle does not support helper and error text.
What is the new behavior?
Adds support for helper and error text, similar to input and textarea.
Does this introduce a breaking change?
Other information