feat(datetime): add showAdjacentDays to display days from the previous and next months#30209
Closed
JoaoFerreira-FrontEnd wants to merge 48 commits intofeature-8.5from
Closed
feat(datetime): add showAdjacentDays to display days from the previous and next months#30209JoaoFerreira-FrontEnd wants to merge 48 commits intofeature-8.5from
JoaoFerreira-FrontEnd wants to merge 48 commits intofeature-8.5from
Conversation
- add showDaysOutsideCurrentMonth property to datetime component; - change month generation to respect new property;
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
package: core
JoaoFerreira-FrontEnd
changed the title
- create specific test page for showDaysOutsideCurrentMonth;
JoaoFerreira-FrontEnd
changed the title
BenOsodrac
requested changes
Feb 27, 2025
BenOsodrac
reviewed
Feb 27, 2025
...onth/datetime.e2e.ts-snapshots/custom-wheel-with-hidden-days-ios-ltr-Mobile-Chrome-linux.png
Outdated
Show resolved
Hide resolved
Contributor
|
@JoaoFerreira-FrontEnd some screenshots are failing, please review this before requesting review 👍 Apart from the comments I already left, I didn't find anything more to comment on! It seems to be working as expected in runtime 💪 |
BenOsodrac
approved these changes
Feb 28, 2025
brandyscarney
changed the title
brandyscarney
requested changes
Mar 7, 2025
Member
brandyscarney
left a comment
brandyscarney
left a comment
There was a problem hiding this comment.
Please see my comment on JIRA for further feedback. 🙂
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
Member
|
Sorry can you reopen this against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: Internal
What is the new behavior?
Adds a new property to datetime,
showAdjacentDays, that when true will show the last days of the previous month and the first days of the next month. This will just occupy empty "cells" at the beginning of the month "table" and add rows to the table until a maximum of 6 rows are displayed.Changes
showAdjacentDaysproperty to datetime componentDoes this introduce a breaking change?
Other information
Preview