feat(react): fixing support for react 19, adding test app for react 19#30217
Merged
ShaneK merged 11 commits intofeature-8.5from Mar 3, 2025
Merged
feat(react): fixing support for react 19, adding test app for react 19#30217ShaneK merged 11 commits intofeature-8.5from
ShaneK merged 11 commits intofeature-8.5from
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ShaneK
changed the title
ShaneK
changed the title
ShaneK
changed the title
ShaneK
changed the title
thetaPC
reviewed
Feb 28, 2025
Contributor
thetaPC
left a comment
thetaPC
left a comment
There was a problem hiding this comment.
There are extra files that are not related to React 19. It seems that they're coming from the fact that feature-8.5 is behind on main. I recommend syncing feature-8.5 to make sure this PR only has the files related to 19.
Other than that, I have one other comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #29991
What is the current behavior?
Currently, there is no test app for React 19. Also, the output test in the react 18 test app is broken because it uses vitest but that file is trying to use jest still.
Additionally, there's issues with using Ionic Framework with React 19 due to several typescript changes. E.g. Issue #29991
What is the new behavior?
Now, there is a test app for React 19 and React 19 should work with Ionic Framework
Does this introduce a breaking change?
Other information