fix(vue): update output target and properly emit events#30227
fix(vue): update output target and properly emit events#30227brandyscarney merged 7 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Verified fix for reproduction case referenced in: #30170 |
|
This does not resolve #30179 |
|
Verified fix for reproduction case referenced in: #30206 |
|
Verified the following issues are broken on
|
ShaneK
left a comment
There was a problem hiding this comment.
I've also tested and verified what Brandy found on 8.4.4-dev.11741193800.14916f6f. Good work! 🚀
|
Can confirm this issue in |
|
Thanks for the fix! |
Issue number: resolves #30206 resolves #30178 resolves #30177 resolves #30175 resolves #30170
What is the current behavior?
There have been plenty of issues reported in regards to Vue components failing to propagate events. It seems like when we updated the Vue output target and started to use the provided runtime code from the output target, we have changed the way how event names are computed. Ionic has used a custom wrapper for handling events that would kebab case event names. That is no longer needed and removing it fixes observed issues.
Reproduction case working: https://stackblitz.com/edit/vj18czas-wdhzxjom?file=package.json
What is the new behavior?
We have received a fix for this in stenciljs/output-targets#617 which I hope will resolve this issue by updating the dependency.
Does this introduce a breaking change?
Other information
Dev build:
8.4.4-dev.11741193800.14916f6f