refactor(modal): allow dragging when expandToScroll is false#30235
Merged
thetaPC merged 2 commits intofeature-8.5from Mar 10, 2025
Merged
refactor(modal): allow dragging when expandToScroll is false#30235thetaPC merged 2 commits intofeature-8.5from
thetaPC merged 2 commits intofeature-8.5from
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
2 tasks
brandyscarney
approved these changes
Mar 10, 2025
Member
brandyscarney
left a comment
brandyscarney
left a comment
There was a problem hiding this comment.
This looks good! We might want to mark this a refactor though since the feature hasn't been released yet.
thetaPC
changed the title
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 18, 2025
…croll is false (#30257) Issue number: internal --------- ## What is the current behavior? Changes introduced by #30235 caused two major issues: - Animations were not being played when increasing breakpoints. - When the scrollable content was at the top, and a big scroll to the bottom of the list was made, the modal would jump to a higher breakpoint. ## What is the new behavior? - When `expandToScroll` is false, the swipe gesture is allowed unless it's a pull down within scrollable content. - When `expandToScroll` is false, we cancel the `moveSheetToBreakpoint` when a scroll to top is being done within the scrollable content ## Does this introduce a breaking change? - [ ] Yes - [x] No ## Other information | Before | After | |--------|-------| | <video src="https://github.com/user-attachments/assets/e1c22f48-f990-45cf-a6c4-1aec0d019c6d"> | <video src="https://github.com/user-attachments/assets/f01e0480-748f-40af-ac11-94f790f0e197"> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
The community has pointed out a missing aspect to the new feature of being able to scroll content on all breakpoints for the sheet modal. It's been verified (by comparing native iOS) that the swipe to close or minimize on content (not handle) is indeed missing but only on a certain conditions:
User can swipe on the content to close when:
User can swipe down to collapse to the next smallest breakpoint
What is the new behavior?
User can swipe on the content to close when:
User can swipe down to collapse to the next smallest breakpoint
Does this introduce a breaking change?
Other information
Preview