test(angular): add a landing page to go between lazy and standalone apps#30286
Merged
brandyscarney merged 1 commit intomainfrom Mar 26, 2025
Merged
test(angular): add a landing page to go between lazy and standalone apps#30286brandyscarney merged 1 commit intomainfrom
brandyscarney merged 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thetaPC
reviewed
Mar 26, 2025
Member
Author
There was a problem hiding this comment.
Sorry I had this set to merge on approval. This file was specific to the ng19 app but I updated the file in the base folder to match this file: https://github.com/ionic-team/ionic-framework/pull/30286/files#diff-174033d040c9d2279d515398002826936441e7892b50ecde6a815fb719c48b9e
Since they are the same now and what's in the base folder works for all versions, this isn't needed.
thetaPC
approved these changes
Mar 26, 2025
Contributor
thetaPC
left a comment
thetaPC
left a comment
There was a problem hiding this comment.
LGTM, thank you so much for this! It's been annoying to test standalone. I also prefer the standalone landing page with the sections. Maybe we can do the same for lazy in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the new behavior?
Adds a landing page to the Angular test app to make it easier to get to and debug standalone.
Does this introduce a breaking change?